Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split coverage and deploy jobs in static.yml to avoid env issue #468

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Split coverage and deploy jobs in static.yml to avoid env issue #468

merged 1 commit into from
Aug 15, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Aug 15, 2024 •
edited
Loading

Trying to narrow down this really weird error by splitting up the two jobs: https://github.com/coder/websocket/actions/runs/10409069016/job/28827848583#step:5:96

--- FAIL: TestWasm (30.09s)
    conn_test.go:371: wasm test binary failed: exit status 1:
        Error: total length of command line and environment variables exceeds limit
            at globalThis.Go.run (http://127.0.0.1:41105/wasm_exec.js:524:11)
            at http://127.0.0.1:41105/:275:14
        exit with status 1
        FAIL	github.com/coder/websocket	16.603s
        FAIL

@mafredri mafredri force-pushed the mafredri/fix-coverage3 branch from e603ea6 to 0f14077 Compare August 15, 2024 19:20
@mafredri mafredri changed the title Reorder entries in static.yml Split coverage and deploy jobs in static.yml to avoid env issue Aug 15, 2024
code-asher
code-asher approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@mafredri mafredri enabled auto-merge August 15, 2024 19:25
@mafredri mafredri merged commit 418f92e into master Aug 15, 2024
8 checks passed
@mafredri mafredri mentioned this pull request Aug 15, 2024
Merged
@mafredri mafredri deleted the mafredri/fix-coverage3 branch August 15, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @code-asher